On 20 June 2013 22:23, Alan Stern <st...@rowland.harvard.edu> wrote:

> On Thu, 20 Jun 2013, Manjunath Goudar wrote:
>
> > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device
> > > *pdev, pm_message_t mesg)
> > > >        * REVISIT: some boards will be able to turn VBUS off...
> > > >        */
> > > >       if (at91_suspend_entering_slow_clock()) {
> > > > -             ohci_usb_reset (ohci);
> > > > +             ohci_restart(ohci);
> > >
> > > Why did you change this?  Did we discuss it earlier?
> > >
> >
> > We are not discussed  regarding this,I think we need to call
> > use ohci_resume() instead of ohci_restart().
>
> Why?  Don't you think the current code has a good reason for calling
> ohci_usb_reset()?
>
>
Here ohci_usb_reset() is static function,that is what I am planing to call
ohci_setup() or ohci_restart() because it is calling  ohci_usb_reset(),
If not calling, we can make ohci_usb_reset() function as non-static
function
or use directly  ohci_usb_reset() function code here.

Let me know which one is good approach.


Alan Stern
>
>
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to