* Maxim Kuvyrkov:

>> On Aug 25, 2023, at 19:18, ci_not...@linaro.org wrote:
>> 
>> Dear contributor, our automatic CI has detected problems related to your 
>> patch.
>> Please find below some details about it.  If you have any questions, please
>> follow up on linaro-toolchain@lists.linaro.org mailing list.
>> 
>> In CI config tcwg_glibc_check/master-aarch64 after:
>> 
>>  | Patchwork URL: 
>> https://patchwork.sourceware.org/project/glibc/patch/871qfr9te6....@oldenburg.str.redhat.com/
>>  | commit 7086332e068cbe778cb47a9baf23cd1d2401444a
>>  | Author: Florian Weimer <fwei...@redhat.com>
>>  | Date:   Fri Aug 25 14:52:01 2023 +0200
>>  | 
>>  |     elf: Check that --list-diagnostics output has the expected syntax
>>  |     
>>  |     Parts of elf/tst-rtld-list-diagnostics.py have been copied from
>>  |     scripts/tst-ld-trace.py.
>>  |     
>>  |     The abnf module is entirely optional and used to verify the
>>  | ... 3 lines of the commit log omitted.
>> 
>> FAIL: 1 regressions
>> 
>> regressions.sum:
>> === glibc tests ===
>> 
>> Running glibc:elf ...
>> FAIL: elf/tst-rtld-list-diagnostics 
>
>
> Hi Florian,
>
> Output of failed test is in [1].
>
> [1] 
> https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/597/artifact/artifacts/artifacts.precommit/00-sumfiles/tests.log.1.xz
>  .

Nope:

| FAIL: elf/tst-rtld-list-diagnostics
| original exit status 1
| info: skipping ABNF validation because the abnf module is missing

The failure is in the “make check” logs:

| Traceback (most recent call last):
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 303, in <module>
|     main(sys.argv[1:])
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 294, in main
|     check_consistency_with_manual(opts.manual)
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 188, in check_consistency_with_manual
|     manual_abnf = extract_lines(manual_path,
|   File 
"/home/tcwg-build/workspace/tcwg_gnu_1/glibc/elf/tst-rtld-list-diagnostics.py", 
line 172, in extract_lines
|     raise ValueError('{!r} not found in {!r}'.format(start_line, path))
| ValueError: '@c ABNF-START' not found in '../manual/dynlink.texi'

Arguably this is a problem in the test/test machinery (we do not
redirect standard error with the Python exceptions).

This likely means that

commit f21962ddfc8bb23e92597da1f98e313dbde11cc1
Author: Florian Weimer <fwei...@redhat.com>
Date:   Fri Aug 25 14:15:28 2023 +0200

    manual: Document ld.so --list-diagnostics output
    
    Reviewed-by: Adhemerval Zanella  <adhemerval.zane...@linaro.org>

was missing during the build.  The original notification said that it
was against this commit:

| Full commit : 
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=7086332e068cbe778cb47a9baf23cd1d2401444a

But that's not a commit hash I can find anywhere else.

Thanks,
Florian

_______________________________________________
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-le...@lists.linaro.org

Reply via email to