> Basic rule-of-thumb: Code that is obviously correct for a reader who did > not know that code before, is good code. > > The rules are as they are because the Linux community is mostly volounteer > work. People may vanish after integrating their changes because they loose > interrest or they cannot find any more time to work on it.
These rules certainly only apply to volunteer projects. Never ever work like this for money ;) Mit freundlichen Grüßen / with kind regards Martin Peschke IBM Deutschland Entwicklung GmbH Linux for zSeries Development Phone: +49-(0)7031-16-2349 |---------+----------------------------> | | Carsten | | | Otte/Germany/IBM@| | | IBMDE | | | Sent by: Linux on| | | 390 Port | | | <[EMAIL PROTECTED]| | | IST.EDU> | | | | | | | | | 10/10/2005 18:39 | | | Please respond to| | | carsteno | | | | |---------+----------------------------> >---------------------------------------------------------------------------------------------------------------| | | | To: LINUX-390@VM.MARIST.EDU | | cc: | | Subject: Re: catfight. | | | >---------------------------------------------------------------------------------------------------------------| David Boyes wrote: > Perhaps one of the positive things to come out of this discussion might be > to set down what those rules *are*. Well that's an easy one: Follow the coding-style guideline and make your code such that John Doe kernel hacker can understand it easily. In case something is not obvious from the code (and only in that case!) do add a comment that clarifies things. Basic rule-of-thumb: Code that is obviously correct for a reader who did not know that code before, is good code. The rules are as they are because the Linux community is mostly volounteer work. People may vanish after integrating their changes because they loose interrest or they cannot find any more time to work on it. In that case, someone who wants to fix something in or take over maintenance of subject device driver needs to be able to sort out things easily without the possibility to ask the original author. If noone cares to maintain a device driver anymore, it is responsibility of the subsystem or architecture maintainer to make sure things keep working. That's why subject maintainer has the right to veto code that he thinks does not meet his expectations. -- Carsten Otte IBM Linux technology center ARCH=s390 ---------------------------------------------------------------------- For LINUX-390 subscribe / signoff / archive access instructions, send email to [EMAIL PROTECTED] with the message: INFO LINUX-390 or visit http://www.marist.edu/htbin/wlvindex?LINUX-390 ---------------------------------------------------------------------- For LINUX-390 subscribe / signoff / archive access instructions, send email to [EMAIL PROTECTED] with the message: INFO LINUX-390 or visit http://www.marist.edu/htbin/wlvindex?LINUX-390