Bjorn Helgaas <[EMAIL PROTECTED]> wrote: > > Andrew, I know it's late in the 2.6.16 cycle, but it would be really > nice if this patch made it. Without it, HPETs on new HP boxes don't > work, so we're going to have to get it in the distros some way or > another.
OK.. What about hpet-fix-acpi-memory-range-length-handling.patch? From: Bjorn Helgaas <[EMAIL PROTECTED]> ACPI address space descriptors contain _MIN, _MAX, and _LEN. _MIN and _MAX are the bounds within which the region can be moved (this is clarified in Table 6-38 of the ACPI 3.0 spec). We should use _LEN to determine the size of the region, not _MAX - _MIN + 1. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/char/hpet.c | 5 +---- 1 files changed, 1 insertion(+), 4 deletions(-) diff -puN drivers/char/hpet.c~hpet-fix-acpi-memory-range-length-handling drivers/char/hpet.c --- 25/drivers/char/hpet.c~hpet-fix-acpi-memory-range-length-handling Tue Feb 7 15:47:01 2006 +++ 25-akpm/drivers/char/hpet.c Tue Feb 7 15:47:01 2006 @@ -925,11 +925,8 @@ static acpi_status hpet_resources(struct status = acpi_resource_to_address64(res, &addr); if (ACPI_SUCCESS(status)) { - unsigned long size; - - size = addr.maximum - addr.minimum + 1; hdp->hd_phys_address = addr.minimum; - hdp->hd_address = ioremap(addr.minimum, size); + hdp->hd_address = ioremap(addr.minimum, addr.address_length); if (hpet_is_known(hdp)) { printk(KERN_DEBUG "%s: 0x%lx is busy\n", _ (It's hard for me to judge when people don't describe what the impact of the problem is, so thanks for the poke). - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html