On Sun, Jun 17, 2007 at 10:24:23PM +0200, Thomas Renninger wrote: > Create __mod_acpi_device_table symbol for all acpi drivers. > > modpost is going to use this one to create modules.alias > > Hopefully thinkpad module still works. > IMO this one should get restructured and make use of acpi_bus_register_driver > and try to avoid to test for HIDs/CIDs for its own. > > Signed-off-by: Thomas Renninger <[EMAIL PROTECTED]>
Tested, except for the compile error already reported it does its job on my vaios. A question though: > Index: linux-2.6.22-rc4/drivers/misc/sony-laptop.c > =================================================================== > --- linux-2.6.22-rc4.orig/drivers/misc/sony-laptop.c > +++ linux-2.6.22-rc4/drivers/misc/sony-laptop.c > @@ -890,10 +890,22 @@ static int sony_nc_remove(struct acpi_de > return 0; > } > > +static const struct acpi_device_id sony_device_ids[] = { > + {SONY_NC_HID, 0}, > + {SONY_PIC_HID, 0}, > + {"", 0}, > +}; > +MODULE_DEVICE_TABLE(acpi, sony_device_ids); > + > +static const struct acpi_device_id sony_nc_device_ids[] = { > + {SONY_NC_HID, 0}, > + {"", 0}, > +}; > + ... > +static const struct acpi_device_id sony_pic_device_ids[] = { > + {SONY_PIC_HID, 0}, > + {"", 0}, > +}; > + is it really necessary to have those duplicate entries? Also, I guess that when this patch set is applied we also should declare sonypi obsolete as sony-laptop will grab the same device that sonypi wants (the SPIC one). sony-laptop has options to avoid doing that would make things clear to users. I still haven't received reports of mafunctioning vaios using the new sony-laptop instead of sonypi but 2.6.22 isn't final yet. -- mattia :wq! - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html