On Thu, 10 Jan 2008, Rafael J. Wysocki wrote: > > > > > > Also, the kerneldoc for destroy_suspended_device() should contain > > > > > > an > > > > > > extra paragraph warning that the routine should never be called > > > > > > except > > > > > > within the scope of a system sleep transition. In practice this > > > > > > means > > > > > > it has to be directly or indirectly invoked by a suspend or resume > > > > > > method. > > > > > > > > > > Or by a CPU hotplug notifier (that will be the majority of cases, > > > > > IMO). > > > > > > > > In your patch the call is made in response to a CPU_UP_CANCELED_FROZEN > > > > notification. Isn't it true that this notification is issued only as > > > > part of a system sleep transition? > > > > > > Yes, it is. > > > > So it counts as being indirectly invoked by a resume method. > > Rather, by the resume core. Technically, it's invoked by > enable_nonboot_cpus(), which is not a resume method literally.
Okay, then the routine should only be called directly or indirectly from a suspend or resume method or from the suspend or resume core. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
