On Jan 18, 2008 7:12 AM, Siddha, Suresh B <[EMAIL PROTECTED]> wrote: > > On Thu, Jan 17, 2008 at 03:04:03PM -0800, Balbir Singh wrote: > > I think I found the root cause of the problem and a fix for it. > > The fix works for me. > > > > Thanks Balbir. But the appended fix is more clean and appropriate. Can you > please check if it works. > --- > > From Balbir Singh: > > > With the introduction of reserve_mattr() and free_mattr(), the ioremap* > > routines > > started exploiting it. The recent 2.6.24-rc8-mm1 kernel has a peculiar > > problem > > where in, certain devices disappear. In my case for example > > > > e100: Intel(R) PRO/100 Network Driver, 3. 5.23-k4-NAPI > > e100: Copyright(c) 1999-2006 Intel Corporation > > ACPI: PCI Interrupt 0000:04:08.0[A] -> GSI 20 (level, low) -> IRQ 20 > > modprobe:2584 conflicting cache attribute 50000000-50001000 > > uncached<->default > > e100: 0000:04:08.0: e100_probe: Cannot map device registers, aborting. > > ACPI: PCI interrupt for device 0000:04:08.0 disabled > > > > On further analysis, it was discovered that quirk_e100_interrupt() calls > > ioremap(), which reserves memory attributes for the e100 card, but > > iounmap() > > does not free it. > > Fix the iounmap() to call free_matrr() unconditionally. > > Signed-off-by: Suresh Siddha <[EMAIL PROTECTED]> > > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
Yes, it looks better. p->flags is always set, so the check was not doing much. I also tested it and it works for me! Tested-by: Balbir Singh <[EMAIL PROTECTED]> Balbir - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
