Hi Magnus, On 30. Aug 2025, at 21:11, Magnus Lindholm wrote: > It can be a bit controversial to replace the platform specific string > manipulation functions with a generic interface. On Alpha, there is nothing > (at least to my knowledge) that indicates that strcpy is broken or used in > an unsafe way and hence this patch doesn't really fix anything. > In my opinion, I think this should be a NAK.
My patch doesn't fix anything, it simply replaces the deprecated strcpy() with the safer strscpy(), without introducing any functional changes. I'm not sure whether the platform-specific strcpy() has any performance benefits over the generic strscpy(), but setup_arch() is already using strscpy() (converted from strlcpy() [1]) to copy the COMMAND_LINE string to 'command_line'. The current code feels unnecessarily inconsistent, with one line using strscpy() and the next using the platform-specific strcpy(). Thanks, Thorsten [1] https://lore.kernel.org/all/[email protected]/
