On Sun, Dec 05, 1999 at 04:29:24PM +0100, Andrea Arcangeli wrote:
> I had to export pdev_fixup_irq because I must avoid
> to reassing the irq for some device and for this reason I can't
> use the plain pci_fixup_irqs unconditional loop.
You did this for the Contaq? This wasn't necessary. We do have code
to properly init the bridge now -- that's what pcibios_assign_special does.
> static struct {
> - unsigned long bits __cacheline_aligned;
> -} ipi_data[NR_CPUS];
> + unsigned long bits ____cacheline_aligned;
> +} ipi_data[NR_CPUS] __cacheline_aligned;
One or the other is sufficient. No need to align both.
> diff -urN 2.3.30pre6/include/asm-alpha/hw_irq.h a/include/asm-alpha/hw_irq.h
> --- 2.3.30pre6/include/asm-alpha/hw_irq.h Thu Jan 1 01:00:00 1970
> +++ a/include/asm-alpha/hw_irq.h Sun Dec 5 15:38:27 1999
> @@ -0,0 +1,91 @@
> +#ifndef _ALPHA_HW_IRQ_H
> +#define _ALPHA_HW_IRQ_H
What was the point of moving this file from arch/alpha/kernel/irq_impl.h?
Yes, there is an include/asm-i386/hw_irq.h, but so what? This is not
something that the rest of the kernel can even remotely use.
> +#define __cacheline_aligned \
> + __attribute__((__aligned__(SMP_CACHE_BYTES), \
> + __section__(".data.cacheline_aligned")))
You can't use this on Alpha without modifying the link script.
r~
