Hello, On Mon, Sep 21, 2015 at 03:03:50PM +0200, Petr Mladek wrote: > +static int khugepaged_has_work(void) > +{ > + return !list_empty(&khugepaged_scan.mm_head) && > + khugepaged_enabled(); > +}
Hmmm... no biggie but this is a bit bothering. > @@ -425,7 +447,10 @@ static ssize_t scan_sleep_millisecs_store(struct kobject > *kobj, > return -EINVAL; > > khugepaged_scan_sleep_millisecs = msecs; > - wake_up_interruptible(&khugepaged_wait); > + if (khugepaged_has_work()) > + mod_delayed_kthread_work(khugepaged_worker, > + &khugepaged_do_scan_work, > + 0); What's wrong with just doing the following? if (khugepaged_enabled()) mod_delayed_kthread_work(...); Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html