On Fri, 20 Nov 2015 15:33:25 +0900 Joonsoo Kim <iamjoonsoo....@lge.com> wrote:
> Steven, is it possible to add tracepoint to inlined fucntion such as > get_page() in include/linux/mm.h? I highly recommend against it. The tracepoint code adds a bit of bloat, and if you inline it, you add that bloat to every use case. Also, it makes things difficult if this file is included in other files that create tracepoints, which I could easily imagine would be the case. That is, if a tracepoint file in include/trace/events/foo.h needs to include include/linux/mm.h, when you do CREATE_TRACEPOINTS for foo.h, it will create tracepoints for mm.h as to use tracepoints there you would need to include the include/trace/events/mm.h (or whatever its name is), and that has caused issues in the past. Now, if you still want to have these tracepoints in the inlined function, it would be best to add a new file mm_trace.h? or something that would include it, and then have only the .c files include that directly. Do not put it into mm.h as that would definitely cause tracepoint include troubles. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
