On Nov 19, 2015, at 2:47 PM, Dave Chinner <da...@fromorbit.com> wrote: > > On Wed, Nov 18, 2015 at 02:14:32PM +0000, Shuichi Ihara wrote: >> >> 11/9/15, 6:28 AM , "Dave Chinner" <da...@fromorbit.com> wrote: >> >>> On Thu, Nov 05, 2015 at 03:13:10PM +0000, Shuichi Ihara wrote: >>>> Hello Ted, Andreas, >>>> >>>> Shilong posted an email here a week ago below. >>>> http://lists.openwall.net/linux-ext4/2015/10/30/2 >>>> >>>> we identified 10 project quota related xfstest and ported them into >>>> ext4/xxx. >>>> test number are 304, 305, 299, 244, 196, 134, 108, 107, 106, 050 in xfs. >>>> >>>> >>>> We ported 9/10 tests into ext4/xxx >>>> ext4/050 ext4/106 ext4/107 ext4/108 ext4/196 ext4/244 ext4/299 ext4/400 >>>> ext4/401 >>> >>> Please make them generic tests - the ext4 project quota >>> functioanlity should work with those tests being completely >>> unchanged except for a "_requires_project_quota()" function... >> >> Right now, we enhanced quotatool to support project quota and above project >> quota tests in ext4 uses that interface. >> xfs uses own interface xfs_xx for project quota tests in xfs. >> what interface are you looking at if we move ext4's project quota tests into >> generic tests? > > The project quota support in the generic quota tool should work XFS > as well as ext4. If it doesn't, then it's not a generic tool, right? > The whole point of having ext4 use the same userspace API as XFS is > so that all quotas can be managed with the one tool. Essentially, if > ext4 project quotas cannot be controlled by xfs_quota, then the ext4 > code is not compatible with XFS and hence still needs work. > > FWIW, if ext4 has implemented the kernel project quota interfaces > correctly, then it should not matter whether we use xfs_quota or the > generic quotatool because the kernel will translate the filesystem > information to whatever format the quota was requested in... > > So, you should be able to simply use the xfs_quota tool in the tests > you make generic without needing any significant modification to the > tests to run them on ext4. Yes, that may mean you need to send a 5 > line patch to make xfs_quota run on ext4, but that's trivial > compared to duplicating >10 tests and then having to maintain them > forever...
I think it also makes sense to have tests for the generic quota tools, which is what current ext4 users will have installed, and not just xfs_quota. This applies to both ext4 and xfs using the generic quota tools with the new interface. In that light, it makes sense to add new tests that use the new quota tools, in addition to testing xfs_quota on XFS and ext4. Cheers, Andreas
signature.asc
Description: Message signed with OpenPGP using GPGMail
