On Fri, 16 Feb 2007 14:00:53 -0800
[EMAIL PROTECTED] wrote:

> Subject: avr32: dma-mapping.h
> From: "Gary Zambrano" <[EMAIL PROTECTED]>
> 
> Added dma_sync_single_range_for_cpu/device to dma-mapping.h in asm-avr32 to
> call dma_sync_single_for_cpu/device.  This patch enables b44 to compile on
> systems with these cpus.  This patch was created with the assumption that
> another method of dma_sync_single_range_for_cpu/device does not exist on these
> architectures.

Thanks. However, I have a couple of questions for the arch experts...

> +static inline void
> +dma_sync_single_range_for_cpu(struct device *dev, dma_addr_t dma_handle,
> +                           unsigned long offset, size_t size,
> +                           enum dma_data_direction direction)
> +{
> +     /* just sync everything, that's all the pci API can do */
> +     dma_sync_single_for_cpu(dev, dma_handle, offset+size, direction);

I'm a little curious about why we can't just do

dma_sync_single_for_cpu(dev, dma_handle + offset, size, direction);

instead?

Also, although not related to this patch in particular, I wonder if we
actually need to sync anything at all in the _for_cpu() functions.
These are analogous to dma_unmap_*(), right?

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to