On Wed, Jun 06, 2007 at 10:19:07PM +0100, Catalin Marinas wrote: > On Wed, 2007-06-06 at 23:10 +0200, Sam Ravnborg wrote: > > On Wed, Jun 06, 2007 at 09:47:49PM +0100, Russell King - ARM Linux wrote: > > > On Wed, Jun 06, 2007 at 08:29:14PM +0200, Sam Ravnborg wrote: > > > > #define FUNCTION(name) .type name, %function > > > > Introducing this simple macro in the generic ARM codebase would > > > > bring down the diff significantly > > > > > > We have such a macro already - ENDPROC(). Recently introduced, > > > we should probably make more use of it. > > Took a short look at include/linux/linkage.h > > There is also ENTRY() that seems resonable to introduce. > > The problem is that ENTRY is not used for functions only (I tried this > initially). The linker needs to know which .globl object is a function > because the Thumb-2 function addresses used in branch instructions have > bit 0 set (even if the address is 2 bytes aligned).
Not suggesting we change ENTRY - that'd be bad. Just add the relevant sprinkling of END and ENDPROC statements in the assembly code (which will add the .size for everything, and .type for functions.) As I say, for existing ARM support it's merely cosmetic which is why there isn't a rush to do it yet, but if it's needed for T2 there's no reason not to. - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
