On Wed, 03 Oct 2007 13:39:39 -0700 [EMAIL PROTECTED] wrote:
>
> 
> diff -puN include/asm-generic/fcntl.h~f_dupfd_cloexec-implementation 
> include/asm-generic/fcntl.h
> --- a/include/asm-generic/fcntl.h~f_dupfd_cloexec-implementation
> +++ a/include/asm-generic/fcntl.h
> @@ -73,6 +73,9 @@
>  #define F_SETSIG     10      /* for sockets. */
>  #define F_GETSIG     11      /* for sockets. */
>  #endif
> +#ifndef F_DUPFD_CLOEXEC
> +#define F_DUPFD_CLOEXEC      12
> +#endif

Why not put

#define F_DUPFD_CLOEXEC         (F_LINUX_SPECIFIC_BASE + 6)

in include/linux/fcntl.h?  That way it will be the same for all
architectures and won't clash with any of them.

F_LINUX_SPECIFIC_BASE is probably badly named.  It was meant to be a
value that was greater than any of the F_ constants for all architestures
so that we could define new F_ constants Linux wide.

Of course, then you would not need f_dupfd_cloexec-implementation-fix.patch
-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgprxcnS5cJMm.pgp
Description: PGP signature

Reply via email to