> -----Original Message-----
> From: [email protected] [mailto:linux-fbdev-
> [email protected]] On Behalf Of Carl Vanderlip
> Sent: Saturday, March 19, 2011 3:22 AM
> To: Russell King; David Brown; Daniel Walker; Bryan Huntsman
> Cc: Brian Swetland; Dima Zavin; Rebecca Schultz Zavin; Colin Cross; linux-
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]; Carl Vanderlip
> Subject: [PATCH 01/20] video: msm: Fix typo 'mpd'->'mdp'
> 
> From: Brian Swetland <[email protected]>
> 
> Trivial fix

The Subject line states that you are only changing a typo from mpd to mdp.
The description doesn't state anything more.
But the patch is changing Copyright info also.
> 
> Authors:
> Dima Zavin <[email protected]>
> Rebecca Schultz Zavin <[email protected]>
> Colin Cross <[email protected]>
> 
> Signed-off-by: Carl Vanderlip <[email protected]>
> ---
>  arch/arm/mach-msm/include/mach/msm_fb.h |    2 +-
>  drivers/video/msm/mdp.c                 |    8 ++++----
>  drivers/video/msm/mdp_ppp.c             |   10 +++++-----
>  drivers/video/msm/msm_fb.c              |    1 -
>  4 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-msm/include/mach/msm_fb.h b/arch/arm/mach-
> msm/include/mach/msm_fb.h
> index 1f4fc81..da11719 100644
> --- a/arch/arm/mach-msm/include/mach/msm_fb.h
> +++ b/arch/arm/mach-msm/include/mach/msm_fb.h
> @@ -114,7 +114,7 @@ struct mdp_blit_req;
>  struct fb_info;
>  struct mdp_device {
>       struct device dev;
> -     void (*dma)(struct mdp_device *mpd, uint32_t addr,
> +     void (*dma)(struct mdp_device *mdp, uint32_t addr,
>                   uint32_t stride, uint32_t w, uint32_t h, uint32_t x,
>                   uint32_t y, struct msmfb_callback *callback, int
> interface);
>       void (*dma_wait)(struct mdp_device *mdp);
> diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c
> index c3636d5..45af97d 100644
> --- a/drivers/video/msm/mdp.c
> +++ b/drivers/video/msm/mdp.c
> @@ -2,7 +2,7 @@
>   *
>   * MSM MDP Interface (used by framebuffer core)
>   *
> - * Copyright (C) 2007 QUALCOMM Incorporated
> + * Copyright (C) 2007, 2011 Code Aurora Forum. All rights reserved.

It is a change from 2007 to 2011 and the company name is being changed.
I think it should be mentioned in the Subject/Description.

>   * Copyright (C) 2007 Google Incorporated
>   *
>   * This software is licensed under the terms of the GNU General Public
> @@ -288,7 +288,7 @@ int mdp_blit(struct mdp_device *mdp_dev, struct
> fb_info *fb,
>       /* WORKAROUND FOR HARDWARE BUG IN BG TILE FETCH */
>       if (unlikely(req->src_rect.h == 0 ||
>                    req->src_rect.w == 0)) {
> -             printk(KERN_ERR "mpd_ppp: src img of zero size!\n");
> +             printk(KERN_ERR "mdp_ppp: src img of zero size!\n");
>               return -EINVAL;
>       }
>       if (unlikely(req->dst_rect.h == 0 ||
> @@ -298,13 +298,13 @@ int mdp_blit(struct mdp_device *mdp_dev, struct
> fb_info *fb,
>       /* do this first so that if this fails, the caller can always
>        * safely call put_img */
>       if (unlikely(get_img(&req->src, fb, &src_start, &src_len,
> &src_file))) {
> -             printk(KERN_ERR "mpd_ppp: could not retrieve src image from "
> +             printk(KERN_ERR "mdp_ppp: could not retrieve src image from "
>                               "memory\n");
>               return -EINVAL;
>       }
> 
>       if (unlikely(get_img(&req->dst, fb, &dst_start, &dst_len,
> &dst_file))) {
> -             printk(KERN_ERR "mpd_ppp: could not retrieve dst image from "
> +             printk(KERN_ERR "mdp_ppp: could not retrieve dst image from "
>                               "memory\n");
>               return -EINVAL;
>       }
> diff --git a/drivers/video/msm/mdp_ppp.c b/drivers/video/msm/mdp_ppp.c
> index 4ff001f..2b04027 100644
> --- a/drivers/video/msm/mdp_ppp.c
> +++ b/drivers/video/msm/mdp_ppp.c
> @@ -1,6 +1,6 @@
>  /* drivers/video/msm/mdp_ppp.c
>   *
> - * Copyright (C) 2007 QUALCOMM Incorporated
> + * Copyright (C) 2007, 2011 Code Aurora Forum. All rights reserved.

Same here.

>   * Copyright (C) 2007 Google Incorporated
>   *
>   * This software is licensed under the terms of the GNU General Public
> @@ -650,7 +650,7 @@ int mdp_ppp_blit(const struct mdp_info *mdp, struct
> mdp_blit_req *req,
> 
>       if (unlikely(req->src.format >= MDP_IMGTYPE_LIMIT ||
>                    req->dst.format >= MDP_IMGTYPE_LIMIT)) {
> -             printk(KERN_ERR "mpd_ppp: img is of wrong format\n");
> +             printk(KERN_ERR "mdp_ppp: img is of wrong format\n");
>               return -EINVAL;
>       }
> 
> @@ -658,7 +658,7 @@ int mdp_ppp_blit(const struct mdp_info *mdp, struct
> mdp_blit_req *req,
>                    req->src_rect.y > req->src.height ||
>                    req->dst_rect.x > req->dst.width ||
>                    req->dst_rect.y > req->dst.height)) {
> -             printk(KERN_ERR "mpd_ppp: img rect is outside of img!\n");
> +             printk(KERN_ERR "mdp_ppp: img rect is outside of img!\n");
>               return -EINVAL;
>       }
> 
> @@ -694,7 +694,7 @@ int mdp_ppp_blit(const struct mdp_info *mdp, struct
> mdp_blit_req *req,
> 
>       if (!valid_src_dst(src_start, src_len, dst_start, dst_len, req,
>                          &regs)) {
> -             printk(KERN_ERR "mpd_ppp: final src or dst location is "
> +             printk(KERN_ERR "mdp_ppp: final src or dst location is "
>                       "invalid, are you trying to make an image too large "
>                       "or to place it outside the screen?\n");
>               return -EINVAL;
> @@ -708,7 +708,7 @@ int mdp_ppp_blit(const struct mdp_info *mdp, struct
> mdp_blit_req *req,
>               regs.op |= PPP_OP_DITHER_EN;
>       blit_blend(req, &regs);
>       if (blit_scale(mdp, req, &regs)) {
> -             printk(KERN_ERR "mpd_ppp: error computing scale for img.\n");
> +             printk(KERN_ERR "mdp_ppp: error computing scale for img.\n");
>               return -EINVAL;
>       }
>       blit_blur(mdp, req, &regs);
> diff --git a/drivers/video/msm/msm_fb.c b/drivers/video/msm/msm_fb.c
> index 5436aeb..04d0067 100644
> --- a/drivers/video/msm/msm_fb.c
> +++ b/drivers/video/msm/msm_fb.c
> @@ -321,7 +321,6 @@ error:
>       mutex_unlock(&msmfb->panel_init_lock);
>  }
> 
> -
>  static int msmfb_check_var(struct fb_var_screeninfo *var, struct fb_info
> *info)
>  {
>       if ((var->xres != info->var.xres) ||
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to