In <URL:news:local.armlinux> on Fri 09 Apr, Russell King - ARM Linux Admin
wrote:
[snip]
> > Once this is done, adfspart_check_ICSLinux() never returns true for me
> > (it never matches the string `LinuxPart'). However, the fdisk code does
> > match this, but seems to be doing the same thing, so I don't know what's
> > going on there. I can't find this string when I look at the disc with
> > Zap.
>
> Have you checked the sectors that are specified in the debug file
> (Pipe:$.C_Debug.*) which are passed to blkio_read during the
> icside_readinfo() function?
Yes. I've got a theory why they're not there.
I've downloaded the newest arm-fdisk (3.0.2) and PartMan (1.13a13). Running
the new fdisk under Linux gives a different result to version 3.0: It lists
all the partitions as being there, but it no longer recognises the last two
as Linux partitions; it doesn't match the `LinuxPart' string.
I notice in the ChangeLog that >2Gb drives are now supported in fdisk
3.0.2. I'm using a 6Gb drive, and the Linux partitions are well above the
2Gb mark. It seems that the old fdisk was probably matching the `LinuxPart'
string much lower down on the disc (some wraparound going on); the new one
looks in the right place and doesn't find it. The newest PartMan behaves
the same as the old fdisk, because as far as I can tell the RISC OS code in
fdisk hasn't changed (it would be nice to have the full PartMan source).
I'd suggest that the kernel not be too fussed about that `LinuxPart' string,
since it doesn't do anything at the moment. Just do, in
adfspart_check_ICS(), something like:
if (p->size < 0) {
/*
* Don't be too fussed if we don't find the string
* that PartMan wrote.
*/
if(adfspart_check_ICSLinux(dev, p->start))
printk(" Linux partition:");
else printk(" Linux partition (probably):");
add_partition(hd, minor, first_sector + -p->start + 1, -p->size - 1);
} else
add_partition(hd, minor, first_sector + p->start, p->size);
I'm guessing you used negative sizes so that the RISC OS IDEFS would think
the partition table had ended.
--
Mark Seaborn
- [EMAIL PROTECTED] - http://www.argonet.co.uk/users/mseaborn/ -
So foul and fair a tagline I have not seen.
unsubscribe: body of `unsubscribe linux-arm' to [EMAIL PROTECTED]
