Re: remap_page_range problem with 2.2.5

[Russell King - ARM Linux Admin]

Eric Thomas writes:
> > >remap_page_range(0xD1000000, 0xc0104000, 0x4D000,
> > >   __pgprot(PTE_TYPE_SMALL | PTE_AP_WRITE))
> > 
> > You probably need to change the access permissions there 
> > because of the new 
> > PTE-handling code.  At a guess you now want (_L_PTE_DEFAULT | 
> > L_PTE_DIRTY | L_PTE_WRITE) or something like that.  You could
> > possibly write that as (PAGE_KERNEL & ~(PTE_BUFFERABLE | PTE_CACHEABLE))
> > to avoid exposing quite so many of the implementation details.
>
> Thanks, that fixed it.  

Oh no it hasn't.  Unfortunately, Phil has misled you here.

PTE_* macros are no longer valid names to be used outside the header
files and the small assembler fragments that live in arch/arm/mm.

_L_PTE_* macros are not to be used outside the pgtable.h header file.

The correct macros to use are the L_PTE_* macros, and the PAGE_* macros.

However, having said that, I note that there is a very big mistake in
your original message - PTE_TYPE_SMALL.  This should not, under any
circumstance be passed into any routine.  The only valid macros you
should be using for the pagetable stuff are the L_PTE_* macros, and
maybe at a far shot the PMD_* macros.
   _____
  |_____| ------------------------------------------------- ---+---+-
  |   |        Russell King       [EMAIL PROTECTED]      --- ---
  | | | |  http://www.arm.linux.org.uk/~rmk/armlinux.html    /  /  |
  | +-+-+                                                     --- -+-
  /   |               THE developer of ARM Linux              |+| /|\
 /  | | |                                                     ---  |
    +-+-+ -------------------------------------------------  /\\\  |
unsubscribe: body of `unsubscribe linux-arm' to [EMAIL PROTECTED]