I have ben studying the ARM 2.3.39 code and have these questions and
comments.

Any other thoughts?


head-armv.S, setup.c, proc-arm6,7.S:
  Why does the system use dynamic detection of processor id's and
  architectures? The code would be simpler and faster if configuration
was
  used to specify those values. Making it no longer necessary to loop
through
  these lists. (SAM)

  If the lists are still needed should the lists in head-armv.S and
setup.c be
  collapsed into one list?

head-armv.S:
  Uses magic numbers in __lookup_processor_type '#36' and in
  __lookup_architecture_type '16'. Should these be replaced with
calculated
  constant definitions? Where should they be defined? (procinfo.h, ???)
(SAM)

  The macro 'inituart' is defined but never referenced. Should it be
moved to
  debug-armv.S?

setup.c:

  setup_processor() - The 'for loop' is repeating what was just done in
  __entry in head-armv.S. It appears to be impossible to make the "CPU
  configuration botched..." message be emitted. (SAM)

S A McConnell






unsubscribe: body of `unsubscribe linux-arm' to [EMAIL PROTECTED]
++        Please use [EMAIL PROTECTED] for           ++
++                        kernel-related discussions.                      ++

Reply via email to