Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

[David Miller]

From: James Morris <[EMAIL PROTECTED]>
Date: Thu, 28 Sep 2006 15:50:42 -0400 (EDT)

> 
> > +struct audit_buffer *netlbl_audit_start_common(int type, u32 secid)
> 
> > +   if (current->mm) {
> > +           down_read(&current->mm->mmap_sem);
> > +           vma = current->mm->mmap;
> > +           while (vma) {
> > +                   if ((vma->vm_flags & VM_EXECUTABLE) &&
> > +                       vma->vm_file) {
> > +                           audit_log_d_path(audit_buf,
> > +                                            " exe=",
> > +                                            vma->vm_file->f_dentry,
> > +                                            vma->vm_file->f_vfsmnt);
> > +                           break;
> > +                   }
> > +                   vma = vma->vm_next;
> > +           }
> > +           up_read(&current->mm->mmap_sem);
> 
> 
> Suggestion for the future: I think it'd be wortwhile consolidating this 
> with the code in audit_log_task_info().
> 
> In any case, the patch looks fine to me.
> 
> Acked-by: James Morris <[EMAIL PROTECTED]>

Applied, thanks a lot.

--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit