Hello,

> @@ -417,8 +409,11 @@ void bio_put(struct bio *bio)
>  
>               if (bio->bi_pool)
>                       bio_free(bio, bio->bi_pool);
> -             else
> -                     bio->bi_destructor(bio);
> +             else {
> +                     if (bio_integrity(bio))
> +                             bio_integrity_free(bio, fs_bio_set);
> +                     kfree(bio);

if {
} else {
}

And wouldn't it be better to make bio_free() handle kfreeing too?

Overall, I really like this change.  I hate how ->bi_destructor() has
been used.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to