On 05/26/12 05:25, Kent Overstreet wrote:
>  struct dm_rq_clone_bio_info {
>       struct bio *orig;
>       struct dm_rq_target_io *tio;
> +     struct bio clone;
>  };
...
> -     pools->bs = bioset_create(pool_size, 0);
> +     pools->bs = bioset_create(pool_size,
> +                               offsetof(struct dm_rq_clone_bio_info, orig));
>       if (!pools->bs)
>               goto free_tio_pool_and_out;

Did you mean offset of *clone*?
"offsetof(struct dm_rq_clone_bio_info, orig)" is zero.

And now _rq_bio_info_cache has no user and can be removed.

Otherwise, I think it's nicer than the previous version.
Thank you.
-- 
Jun'ichi Nomura, NEC Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to