On Thu, Mar 07, 2024 at 12:39:58PM -0500, Kent Overstreet wrote: > On Mon, Mar 04, 2024 at 10:18:22AM +0100, Christian Brauner wrote: > > On Sat, Mar 02, 2024 at 05:02:03PM -0500, Kent Overstreet wrote: > > > Add a new statx field for (sub)volume identifiers. > > > > > > This includes bcachefs support; we'll definitely want btrfs support as > > > well. > > > > > > Link: > > > https://lore.kernel.org/linux-fsdevel/2uvhm6gweyl7iyyp2xpfryvcu2g3padagaeqcbiavjyiis6prl@yjm725bizncq/ > > > Signed-off-by: Kent Overstreet <kent.overstr...@linux.dev> > > > Cc: Josef Bacik <jo...@toxicpanda.com> > > > Cc: Miklos Szeredi <mszer...@redhat.com> > > > Cc: Christian Brauner <brau...@kernel.org> > > > Cc: David Howells <dhowe...@redhat.com> > > > --- > > > > As I've said many times before I'm supportive of this and would pick up > > a patch like this. There's definitely a lot of userspace that would make > > use of this that I'm aware of. If the btrfs people could provide an Ack > > on this to express their support here that would be great. > > > > And it would be lovely if we could expand the commit message a bit and > > do some renaming/bikeshedding. Imho, STATX_SUBVOLUME_ID is great and > > then stx_subvolume_id or stx_subvol_id. And then subvolume_id or > > subvol_id for the field in struct kstat. > > _id is too redundant for me, can we just do STATX_SUBVOL/statx.subvol?
Fine by me.
