On Tue, Nov 12, 2024 at 10:55:39PM +0800, Hongbo Li wrote: > On 2024/11/12 10:14, Kent Overstreet wrote: > > + unsigned orig_pos2 = path->pos; > > + prt_bytes(path, dirent_name.name, dirent_name.len); > > + reverse_bytes(path->buf + orig_pos2, path->pos - orig_pos2); > These two line can be replaced with prt_bytes_reversed helper.
yup > > + > > + prt_char(path, '/'); > > + > > + if (d.v->d_type == DT_SUBVOL) > > + inum.subvol = le32_to_cpu(d.v->d_parent_subvol); > > + inum.inum = d.k->p.inode; > > + > > + bch2_trans_iter_exit(trans, &d_iter); > > + } > > + > > + if (!path->pos) > The condition should be if (orig_pos == path->) ? good catch, that was from an earlier version of the patch
