[PATCH 17/18] bcachefs: Split out dirent alloc and name initialization

[Kent Overstreet]

From: Joshua Ashton <jos...@froggi.es>

Splits out the code that allocates the dirent and initializes the name
to make things easier to implement casefolding in a future commit.

Signed-off-by: Joshua Ashton <jos...@froggi.es>

Cc: André Almeida <andrealm...@igalia.com>
Cc: Gabriel Krisman Bertazi <kris...@suse.de>
Signed-off-by: Kent Overstreet <kent.overstr...@linux.dev>
---
 fs/bcachefs/dirent.c | 46 ++++++++++++++++++++++++++++++++------------
 1 file changed, 34 insertions(+), 12 deletions(-)

diff --git a/fs/bcachefs/dirent.c b/fs/bcachefs/dirent.c
index 27737aaa03a6..7dcc18000726 100644
--- a/fs/bcachefs/dirent.c
+++ b/fs/bcachefs/dirent.c
@@ -163,15 +163,13 @@ void bch2_dirent_to_text(struct printbuf *out, struct 
bch_fs *c, struct bkey_s_c
        prt_printf(out, " type %s", bch2_d_type_str(d.v->d_type));
 }
 
-static struct bkey_i_dirent *dirent_create_key(struct btree_trans *trans,
-                               subvol_inum dir, u8 type,
-                               const struct qstr *name, u64 dst)
+static struct bkey_i_dirent *dirent_alloc_key(struct btree_trans *trans,
+                               subvol_inum dir,
+                               u8 type,
+                               int name_len, u64 dst)
 {
        struct bkey_i_dirent *dirent;
-       unsigned u64s = BKEY_U64s + dirent_val_u64s(name->len);
-
-       if (name->len > BCH_NAME_MAX)
-               return ERR_PTR(-ENAMETOOLONG);
+       unsigned u64s = BKEY_U64s + dirent_val_u64s(name_len);
 
        BUG_ON(u64s > U8_MAX);
 
@@ -191,11 +189,35 @@ static struct bkey_i_dirent *dirent_create_key(struct 
btree_trans *trans,
 
        dirent->v.d_type = type;
 
-       memcpy(dirent->v.d_name, name->name, name->len);
-       memset(dirent->v.d_name + name->len, 0,
-              bkey_val_bytes(&dirent->k) -
-              offsetof(struct bch_dirent, d_name) -
-              name->len);
+       return dirent;
+}
+
+static void dirent_init_regular_name(struct bkey_i_dirent *dirent,
+                                    const struct qstr *name)
+{
+       memcpy(&dirent->v.d_name[0], name->name, name->len);
+       memset(&dirent->v.d_name[name->len], 0,
+               bkey_val_bytes(&dirent->k) -
+               offsetof(struct bch_dirent, d_name) -
+               name->len);
+}
+
+static struct bkey_i_dirent *dirent_create_key(struct btree_trans *trans,
+                               subvol_inum dir,
+                               u8 type,
+                               const struct qstr *name,
+                               u64 dst)
+{
+       struct bkey_i_dirent *dirent;
+
+       if (name->len > BCH_NAME_MAX)
+               return ERR_PTR(-ENAMETOOLONG);
+
+       dirent = dirent_alloc_key(trans, dir, type, name->len, dst);
+       if (IS_ERR(dirent))
+               return dirent;
+
+       dirent_init_regular_name(dirent, name);
 
        EBUG_ON(bch2_dirent_name_bytes(dirent_i_to_s_c(dirent)) != name->len);
 
-- 
2.45.2