On Fri, Jun 20, 2025 at 10:03:03AM +0800, Alan Huang wrote: > > > > On Jun 20, 2025, at 04:35, Kent Overstreet <[email protected]> > > wrote: > > > > On Fri, Jun 20, 2025 at 03:58:26AM +0800, Alan Huang wrote: > >> Signed-off-by: Alan Huang <[email protected]> > >> --- > >> fs/bcachefs/btree_iter.c | 65 ++++++++++++++++++++-------------------- > >> fs/bcachefs/btree_iter.h | 14 +++++++++ > >> 2 files changed, 46 insertions(+), 33 deletions(-) > >> > >> diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c > >> index 352f9cd2634f..0168c4023c74 100644 > >> --- a/fs/bcachefs/btree_iter.c > >> +++ b/fs/bcachefs/btree_iter.c > >> @@ -3238,32 +3238,30 @@ void *__bch2_trans_kmalloc(struct btree_trans > >> *trans, size_t size, unsigned long > >> } > >> > >> EBUG_ON(trans->mem); > >> + EBUG_ON(trans->mem_bytes); > >> + EBUG_ON(trans->mem_top); > > > > ??? > > It’s the first time we allocate memory.
Ok, I went and looked at the actual code from your repository; the diff was missing critical context. And it does look nicer when I'm looking at the code and not the diff - I'll go ahead and apply it.
