On Fri, 2017-08-18 at 08:35 -0600, Jens Axboe wrote:
> On Thu, Aug 17 2017, Bart Van Assche wrote:
> > It is easy to add a flag to one of the block layer headers and to
> > forget to update blk-mq-debugfs.c. E.g. QUEUE_FLAG_SCSI_PASSTHROUGH,
> > QUEUE_FLAG_QUIESCED and REQ_NOWAIT are missing from blk-mq-debugfs.c.
> > Hence generate the symbol-to-text translation tables.
> 
> This is just too ugly to live...

Hello Jens,

How about adding rules to the makefile that check for missing symbols and
that issue a warning if a symbol is missing from blk-mq-debugfs.c? Would
you consider that approach acceptable?

Bart.

Reply via email to