On Wed, Nov 01, 2017 at 02:47:22PM +0100, Jan Kara wrote:
> On Tue 31-10-17 18:38:24, weiping zhang wrote:
> > In order to make error handle more cleaner we call bdi_debug_register
> > before set state to WB_registered, that we can avoid call bdi_unregister
> > in release_bdi().
> >
> > Signed-off-by: weiping zhang <zhangweip...@didichuxing.com>
>
> Looks good to me. You can add:
>
> Reviewed-by: Jan Kara <j...@suse.cz>
>
> Honza
>
> > ---
> > mm/backing-dev.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> > index b5f940ce0143..84b2dc76f140 100644
> > --- a/mm/backing-dev.c
> > +++ b/mm/backing-dev.c
> > @@ -882,10 +882,13 @@ int bdi_register_va(struct backing_dev_info *bdi,
> > const char *fmt, va_list args)
> > if (IS_ERR(dev))
> > return PTR_ERR(dev);
> >
> > + if (bdi_debug_register(bdi, dev_name(dev))) {
> > + device_destroy(bdi_class, dev->devt);
> > + return -ENOMEM;
> > + }
> > cgwb_bdi_register(bdi);
> > bdi->dev = dev;
> >
> > - bdi_debug_register(bdi, dev_name(dev));
> > set_bit(WB_registered, &bdi->wb.state);
> >
> > spin_lock_bh(&bdi_lock);
> > --
Hello Jens,
Could you please give some comments for this series cleanup.
--
Thanks
weiping
