Re: [PATCH] lightnvm/pblk-gc: Delete an error message for a failed memory allocation in pblk_gc_line_prepare_ws()

[Javier González]

> On 16 Jan 2018, at 22.10, SF Markus Elfring <elfr...@users.sourceforge.net> 
> wrote:
> 
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Tue, 16 Jan 2018 22:00:15 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
> ---
> drivers/lightnvm/pblk-gc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
> index 9c8e114c8a54..54cdb4360366 100644
> --- a/drivers/lightnvm/pblk-gc.c
> +++ b/drivers/lightnvm/pblk-gc.c
> @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct 
> *work)
>       int ret;
> 
>       invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL);
> -     if (!invalid_bitmap) {
> -             pr_err("pblk: could not allocate GC invalid bitmap\n");
> +     if (!invalid_bitmap)
>               goto fail_free_ws;
> -     }
> 
>       emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type,
>                                                               GFP_KERNEL);
> --
> 2.15.1

Looks good to me.

Reviewed-by: Javier González <jav...@cnexlabs.com>

signature.asc
Description: Message signed with OpenPGP