On 5/18/18 10:23 AM, Christoph Hellwig wrote: > On Fri, May 11, 2018 at 03:13:38PM -0600, Jens Axboe wrote: >> Looked over the series, and looks like both good cleanups and optimizations. >> If we can get the mempool patch sorted, I can apply this for 4.18. > > FYI, I agree on the actual cleanups and optimization, but we really > shouldn't add new functions or even just exports without the code > using them. I think it is enough if we can collect ACKs on them, but > there is no point in using them. Especially as I'd really like to see > the users for some of them first.
I certainly agree on that in general, but at the same time it makes the expected submission of bcachefs not having to carry a number of (essentially) unrelated patches. I'm assuming the likelihood of bcachefs being submitted soonish is high, hence we won't have exports that don't have in-kernel users in the longer term. -- Jens Axboe