On Tue, May 29, 2018 at 05:15:34PM +0000, Verkamp, Daniel wrote: > This looks overly restrictive - a host sending a Set Features with e.g. the > health critical warning bits set in CDW11 will get a failure. As far as I > can tell, this isn't allowed by the spec; Set Features - Asynchronous Event > Configuration and the health log page have been mandatory since NVMe 1.0, and > presumably support for the corresponding health log page related AER bits is > also mandatory (these were the only bits available in NVMe 1.0).
Agreed so far. > I think it should be fine to just allow the user to set any (valid) > combination of bits here, while still only triggering the NS Changed > notification. Disagreeing here. Catching completely bogus bits that the hosts sets is important.
