On 11/8/18 6:25 AM, Jan Kara wrote: > On Thu 08-11-18 06:21:21, Jens Axboe wrote: >> On 11/8/18 6:01 AM, Jan Kara wrote: >>> Hi, >>> >>> this patch series fixes oops and possible deadlocks as reported by syzbot >>> [1] >>> [2]. The second patch in the series (from Tetsuo) fixes the oops, the >>> remaining >>> patches are cleaning up the locking in the loop driver so that we can in the >>> end reasonably easily switch to rereading partitions without holding mutex >>> protecting the loop device. >>> >>> I have tested the patches by creating, deleting, modifying loop devices, >>> and by >>> running loop blktests (as well as creating new ones with the load syzkaller >>> has >>> used to detect the problem). Review is welcome but I think the patches are >>> fine >>> to go as far as I'm concerned! Jens, can you please pick them up? >> >> I've been waiting for this series - it's a big series for 4.20, though... It >> would suck having to defer this to 4.21 since it's a long standing issue, but >> the risk of a new regression is present as well. >> >> Are you fine with this going in for 4.21? > > Yeah, I'm fine with the delay so that it has time to soak in linux-next.
Sounds good - thanks for getting this work done, much appreciated. I have applied it for 4.21. -- Jens Axboe