Re: [PATCH nvme-cli v2 15/14] nvme: Add TCP transport

[Sagi Grimberg]

@@ -703,11 +704,13 @@ retry:
         /* we can safely ignore the rest of the entries */
         break;
     case NVMF_TRTYPE_RDMA:
+    case NVMF_TRTYPE_TCP:
         switch (e->adrfam) {
         case NVMF_ADDR_FAMILY_IP4:
         case NVMF_ADDR_FAMILY_IP6:
             /* FALLTHRU */
-            len = sprintf(p, ",transport=rdma");
+            len = sprintf(p, ",transport=%s",
+                e->trtype == NVMF_TRTYPE_RDMA ? "rdma" : "tcp");

So why not just use the trtypes array above?

We can use that...