On Mon, Nov 26, 2018 at 04:19:38PM -0500, Dennis Zhou wrote:
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 62715a5a4f32..8bc9d9b29fd3 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -486,6 +486,12 @@ extern unsigned int bvec_nr_vecs(unsigned short idx);
> extern const char *bio_devname(struct bio *bio, char *buffer);
>
> #define bio_set_dev(bio, bdev) \
> +do { \
> + bio_set_dev_only(bio, bdev); \
> + bio_associate_blkg(bio); \
> +} while (0)
> +
> +#define bio_set_dev_only(bio, bdev) \
> do { \
> if ((bio)->bi_disk != (bdev)->bd_disk) \
> bio_clear_flag(bio, BIO_THROTTLED);\
Generally looks okay to me but I'm not sure about bio_set_dev_only().
Maybe sth more explicit like bio_set_dev_without_blkg()? Also, can
you please add comments explaining which should be used when?
Thanks.
--
tejun
