On 12/16/18 9:09 AM, Christoph Hellwig wrote:
> On Sun, Dec 16, 2018 at 09:04:37AM -0700, Jens Axboe wrote:
>> It would fit better with the style in that code do to:
>>
>> rqos = q->rq_qos;
>> while (rqos) {
>> ....
>> rqos = rqos->next;
>> }
>
> But that is just a really strangly written for loop to start with..
I think it looks fine, and it's more readable than using a for()
loop for something like this.
> Maybe Bart need to send a cleanup patch for the whole file, especially
> given that this patch has been applied already.
As mentioned in the same thread, I dropped these since I had to
amend a commit anyway. So we're free to do whatever.
--
Jens Axboe
