On 1/28/19 11:29 PM, Christoph Hellwig wrote: > On Mon, Jan 28, 2019 at 10:05:37AM -0700, Jens Axboe wrote: >>>> 2) Probably want the application to pass in the appropriate grace >>>> period, not hard code it at 1 second. >>> >>> 2) actually sounds really useful. Should we look into it ASAP? >> >> I think so. Question is what kind of granularity we need for this. I >> think we can go pretty coarse and keep it in msec, using a short to >> pass this in like we do for the thread CPU. That gives us 0..65535 msec, >> which should be plenty of range. > > msec granualarity sounds fine. But is it really worth using a short > instead of a 32-bit value these days? > > Also 16385 seems very limiting for a cpu value, especially as our > normal cpu ids are ints.
I'll bump them both to 4-bytes. -- Jens Axboe
