> On 18 Mar 2019, at 16.27, Marcin Dziegielewski > <[email protected]> wrote: > > In current implementation of l2p recovery, when we are after > gc and we have open line, we are not setting current data line > properly (we set last line from the device instead of last line > ordered by seq_nr) and in consequence, kernel panic and > data corruption. This patch fixes that issue. > > Signed-off-by: Marcin Dziegielewski <[email protected]> > --- > drivers/lightnvm/pblk-recovery.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/lightnvm/pblk-recovery.c > b/drivers/lightnvm/pblk-recovery.c > index 83b467b..017874e 100644 > --- a/drivers/lightnvm/pblk-recovery.c > +++ b/drivers/lightnvm/pblk-recovery.c > @@ -844,6 +844,7 @@ struct pblk_line *pblk_recov_l2p(struct pblk *pblk) > spin_unlock(&l_mg->free_lock); > } else { > spin_lock(&l_mg->free_lock); > + l_mg->data_line = data_line; > /* Allocate next line for preparation */ > l_mg->data_next = pblk_line_get(pblk); > if (l_mg->data_next) { > -- > 1.8.3.1
I think you are right. Good catch. Reviewed-by: Javier González <[email protected]>
signature.asc
Description: Message signed with OpenPGP
