On 2019-08-14 8:26 a.m., Max Gurtovoy wrote: > > On 8/2/2019 2:45 AM, Logan Gunthorpe wrote: >> From: Chaitanya Kulkarni <[email protected]> >> >> Change the return value for nvmet_add_async_event(). >> >> This change is needed for the target passthru code to generate async >> events. > > As a stand alone commit it's not clear what is the purpose of it. > > Please add some extra explanation in the commit message. > > Also better to use integer as return value if the return value should > reflect return code. Thanks for the Review, Max. I'll queue up these changes for v8. Logan
- [PATCH v7 06/14] nvmet-passthru: add passthru code to p... Logan Gunthorpe
- [PATCH v7 14/14] nvmet-passthru: support block accounti... Logan Gunthorpe
- [PATCH v7 12/14] block: don't check blk_rq_is_passthrou... Logan Gunthorpe
- [PATCH v7 13/14] block: call blk_account_io_start() in ... Logan Gunthorpe
- [PATCH v7 04/14] nvmet: make nvmet_copy_ns_identifier()... Logan Gunthorpe
- Re: [PATCH v7 04/14] nvmet: make nvmet_copy_ns_ide... Max Gurtovoy
- Re: [PATCH v7 04/14] nvmet: make nvmet_copy_ns... Chaitanya Kulkarni
- [PATCH v7 03/14] nvmet: add return value to nvmet_add_... Logan Gunthorpe
- Re: [PATCH v7 03/14] nvmet: add return value to nv... Max Gurtovoy
- Re: [PATCH v7 03/14] nvmet: add return value t... Logan Gunthorpe
- [PATCH v7 01/14] nvme-core: introduce nvme_ctrl_get_by_... Logan Gunthorpe
- Re: [PATCH v7 01/14] nvme-core: introduce nvme_ctr... Max Gurtovoy
- Re: [PATCH v7 01/14] nvme-core: introduce nvme_ctr... Max Gurtovoy
- Re: [PATCH v7 01/14] nvme-core: introduce nvme... Logan Gunthorpe
