On 9/12/19 5:47 PM, Jens Axboe wrote: > On 9/12/19 9:47 AM, Ezequiel Garcia wrote: >> Hi André, Jens, >> >> On Wed, 2019-09-11 at 11:46 -0300, André Almeida wrote: >>> The name of the module is "null_blk", not "null". Make `pr_info()` follow >>> the pattern of `pr_err()` log messages. >>> >> >> Instead of doing these fixes manually, it's more consistent and smarter >> to use pr_fmt. There are many examples of drivers doing that. >> >> I don't know if this patch can be dropped, and replaced with one used pr_fmt >> or if doesn't worth the trouble. >> >> It would be even better to also patch Documentation/process/coding-style.rst, >> in particular the printing section, making a mention to pr_fmt. > > André, please address the comments in this email and from Willy. Note > that the previous patch is queued up, so you'll need to make it relative > to that. >
Ok Jens, I'll do it.
