Hi, I claim, that there is a bug, that hopefully doesn't show itself apart from a minor disabled optimisation. It's _too_ easy to misuse, and if somebody try to reuse, this could lead to quite interesting issues.
Could somebody at last take a look? Thanks On 25/07/2019 00:35, Pavel Begunkov (Silence) wrote: > From: Pavel Begunkov <asml.sile...@gmail.com> > > There are implicit assumptions about struct blk_rq_stats, which make > it's very easy to misuse. The first patch fixes consequences, and the > second employs type-system to prevent recurrences. > > Acked-by: Josef Bacik <jo...@toxicpanda.com> > > Pavel Begunkov (2): > blk-iolatency: Fix zero mean in previous stats > blk-stats: Introduce explicit stat staging buffers > > block/blk-iolatency.c | 60 ++++++++++++++++++++++++++++++--------- > block/blk-stat.c | 48 +++++++++++++++++++++++-------- > block/blk-stat.h | 9 ++++-- > include/linux/blk_types.h | 6 ++++ > 4 files changed, 94 insertions(+), 29 deletions(-) > -- Yours sincerely, Pavel Begunkov
signature.asc
Description: OpenPGP digital signature
