On Tue, 15 Oct 2019 02:06:41 -0700 Christoph Hellwig <[email protected]> wrote:
> > + /*
> > + * Zoned block device contains zones that have
> > + * sequential write only restriction. For the restriction,
> > + * zoned block devices are not suitable for a swap device.
> > + * Disallow them here.
> > + */
> > + if (blk_queue_is_zoned(p->bdev->bd_queue))
>
> Please use up all 80 chars per line Otherwise this looks fine:
I redid the text a bit as well.
--- a/mm/swapfile.c~mm-swap-disallow-swapon-on-zoned-block-devices-fix
+++ a/mm/swapfile.c
@@ -2888,10 +2888,9 @@ static int claim_swapfile(struct swap_in
if (error < 0)
return error;
/*
- * Zoned block device contains zones that have
- * sequential write only restriction. For the restriction,
- * zoned block devices are not suitable for a swap device.
- * Disallow them here.
+ * Zoned block devices contain zones that have a sequential
+ * write only restriction. Hence zoned block devices are not
+ * suitable for swapping. Disallow them here.
*/
if (blk_queue_is_zoned(p->bdev->bd_queue))
return -EINVAL;
_
