On Fri, Oct 18, 2019 at 4:01 PM Jens Axboe <[email protected]> wrote: > On 10/17/19 8:41 PM, Jann Horn wrote: > > On Fri, Oct 18, 2019 at 4:01 AM Jens Axboe <[email protected]> wrote: > >> This is in preparation for adding opcodes that need to modify files > >> in a process file table, either adding new ones or closing old ones. [...] > Updated patch1: > > http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.5/io_uring-test&id=df6caac708dae8ee9a74c9016e479b02ad78d436
I don't understand what you're doing with old_files in there. In the "s->files && !old_files" branch, "current->files = s->files" happens without holding task_lock(), but current->files and s->files are also the same already at that point anyway. And what's the intent behind assigning stuff to old_files inside the loop? Isn't that going to cause the workqueue to keep a modified current->files beyond the runtime of the work?
