On 1/6/25 7:06 PM, Christoph Hellwig wrote:
> So far cache_type_store didn't freeze the queue, fix that by using the
> queue_limits_commit_update_frozen helper.
> 
> Signed-off-by: Christoph Hellwig <[email protected]>

This should be squashed in patch 2, no ?

> ---
>  drivers/block/virtio_blk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 0a987f195630..bbaa26b523b8 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -1105,7 +1105,7 @@ cache_type_store(struct device *dev, struct 
> device_attribute *attr,
>               lim.features |= BLK_FEAT_WRITE_CACHE;
>       else
>               lim.features &= ~BLK_FEAT_WRITE_CACHE;
> -     i = queue_limits_commit_update(disk->queue, &lim);
> +     i = queue_limits_commit_update_frozen(disk->queue, &lim);
>       if (i)
>               return i;
>       return count;


-- 
Damien Le Moal
Western Digital Research

Reply via email to