On Fri, May 09, 2025 at 10:38:32AM +0800, Ming Lei wrote: > > +static bool blk_mq_map_hk_queues(struct blk_mq_queue_map *qmap) > > +{ > > + struct cpumask *hk_masks; > > + cpumask_var_t isol_mask; > > + unsigned int queue, cpu, nr_masks; > > + > > + if (!housekeeping_enabled(HK_TYPE_IO_QUEUE)) > > + return false; > > It could be more readable to move the above check to the caller.
I wanted to avoid checking if housekeeping is enabled twice in a row. I'll post the next version with your suggestion and see if this approach is better.