Re: [PATCH v2 11/33] net: use ns_common_init()

[Al Viro]

On Fri, Sep 12, 2025 at 01:52:34PM +0200, Christian Brauner wrote:

> +     ret = ns_common_init(&net->ns, ns_ops, false);
                                               ^^^^^
> +     if (ret)
> +             return ret;

How would that possibly fail?  You are not trying to grab inum here,
what's there to fail?

> @@ -559,7 +572,9 @@ struct net *copy_net_ns(unsigned long flags,
>               goto dec_ucounts;
>       }
>  
> -     preinit_net(net, user_ns);
> +     rv = preinit_net(net, user_ns);
> +     if (rv < 0)
> +             goto dec_ucounts;

Ditto.