Re: [PATCH 7/9] blk-crypto: use mempool_alloc_bulk for encrypted bio page allocation

[Eric Biggers]

On Tue, Jan 06, 2026 at 08:36:30AM +0100, Christoph Hellwig wrote:
> +out_free_enc_bio:
> +     /*
> +      * Add the remaining pages to the bio so that the normal completion path
> +      * in blk_crypto_fallback_encrypt_endio frees them.  The exact data
> +      * layout does not matter for that, so don't bother iterating the source
> +      * bio.
> +      */
> +     for (; enc_idx < nr_enc_pages; enc_idx++)
> +             __bio_add_page(enc_bio, enc_pages[enc_idx++], PAGE_SIZE, 0);
> +     bio_io_error(enc_bio);

There's a double increment above.

Otherwise this looks okay.

- Eric