On Sun, Oct 18, 2015 at 07:41:27PM +0800, Qu Wenruo wrote: > 在 2015年10月18日 13:44, Liu Bo 写道: > > Btrfs has changed to delete subvolume/snapshot asynchronously, which means > > that > > after umount itself, if we've already deleted 'ext2_saved', rollback can > > still > > be completed. > > > > So this adds a check for ROOT_BACKREF before checking ROOT_ITEM since > > ROOT_BACKREF is immediately not in the btree after > > ioctl(BTRFS_IOC_SNAP_DESTROY) > > returns. > > > > Signed-off-by: Liu Bo <[email protected]> > Reviewed-by: Qu Wenruo <[email protected]> > > Looks good to me. > > Although the error message for ret > 0 case can be improved a little, like: > "unable to find convert image subvolume, maybe it's already deleted?\n".
I've adjusted the error messages. > BTW, would you please submit a test case for fstests? It won't be a hard > one though. Test added. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
