On Mon, Nov 28, 2016 at 09:40:07AM +0800, Qu Wenruo wrote: > Goldwyn Rodrigues has exposed and fixed a bug which underflows btrfs > qgroup reserved space, and leads to non-writable fs. > > This reminds us that we don't have enough underflow check for qgroup > reserved space. > > For underflow case, we should not really underflow the numbers but warn > and keeps qgroup still work. > > So add more check on qgroup reserved space and add WARN_ON() and > btrfs_warn() for any underflow case. > > Signed-off-by: Qu Wenruo <[email protected]> > Reviewed-by: David Sterba <[email protected]>
One of the warnings is visible during xfstests (btrfs_qgroup_free_refroot), is there a fix? Either a patch in mailinglist or work in progress. If not, I'm a bit reluctant to add it to 4.10 as we'd get that reported from users for sure. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
