On Tue, Feb 16, 2021 at 04:28:40PM +0000, Sidong Yang wrote:
> Remove a code that inserting new line in fmt_end() for text mode.
> Old code made a failure in fstest btrfs/006.
>
> Signed-off-by: Sidong Yang <[email protected]>
> ---
> Hi, I've just read mail that Filipe written that some failure about fstest.
> I'm worried about this patch makes other problem. So make it RFC. Thanks.
I found the discussion under the device stats patch adding json, the
added line was known and "hopefully not causing problems", but the
fstests seem to notice.
I think we can fix that by removing the fmt_end newline but we also need
to update how the fmt_print is done for the text output. Ie. for json
there are some strict rules for line continuations (",") but for the
textual output, each line ended by "\n" right away, without delaying
that to the next fmt_* call should work.