2010/1/27 Liuwenyi <qingshen...@gmail.com>: > In this patch, I adjust the seqence of if-conditions. > It will assess the page->private situation. > First, we make sure the page->private is not null. > And then, we can do some with this page->private. > > --- > Signed-off-by: Liuwenyi <qingshen...@gmail.com> > Cc: Chris Mason <chris.ma...@oracle.com> > Cc: Yan Zheng <zheng....@oracle.com> > Cc: Josef Bacik <jba...@redhat.com> > Cc: Jens Axboe <jens.ax...@oracle.com> > Cc: linux-btrfs@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > > --- > fs/btrfs/disk-io.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > index 009e3bd..a300dca 100644 > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -1407,11 +1407,11 @@ static int bio_ready_for_csum(struct bio *bio) > > bio_for_each_segment(bvec, bio, i) { > page = bvec->bv_page; > - if (page->private == EXTENT_PAGE_PRIVATE) { > + if (!page->private) { > length += bvec->bv_len; > continue; > } > - if (!page->private) { > + if (page->private == EXTENT_PAGE_PRIVATE) { > length += bvec->bv_len; > continue; > } > --
Why do you want to do this? The code is perfect safe even page->private is NULL. Furthermore, your patch is malformed. Yan, Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html